Page MenuHomePhabricator

[Cashtab] Add props validation and clean up resulting lint errors
ClosedPublic

Authored by bytesofman on Aug 31 2021, 22:51.

Details

Summary

T1723

React supports basic type checking for development which is useful in debugging or catching errors. Cashtab did not have this previously. It always "should" have been there, but might as well start now.

Removed any unused props from the check. Standardized format of export default for any component that is the only component in a file.

Test Plan

npm start
Click through all screens with dev console open and verify no errors.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien added a subscriber: Fabien.

Please don't sneak in unrelated changes, that just makes reviewing more confusing

web/cashtab/src/components/Common/CustomIcons.js
10 ↗(On Diff #29707)

That seems unrelated to the diff

This revision is now accepted and ready to land.Sep 1 2021, 06:52