Call SHA256AutoDetect in benchmark setup
ClosedPublic
Actions

Authored by PiRK on Sep 1 2021, 09:26.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC4d0d32567acc: Call SHA256AutoDetect in benchmark setup

Summary

It seems SHA256AutoDetect() was not being called in benchmarks, making the numbers only reflect the naive implementation. Fix this by calling it in bench_bitcoin's setup.

This is a backport of core#19214

Test Plan

ninja bench-bitcoin

I don't see a significant difference in the SHA256 becnhmarks before or
after this commit.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 1 2021, 09:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 1 2021, 09:26

PiRK requested review of this revision.Sep 1 2021, 09:26

teamcity edited the summary of this revision. (Show Details)Sep 1 2021, 09:26

Harbormaster completed remote builds in B16504: Diff 29717.Sep 1 2021, 09:57

majcosta accepted this revision.Sep 1 2021, 10:45

This revision is now accepted and ready to land.Sep 1 2021, 10:45

Closed by commit rABC4d0d32567acc: Call SHA256AutoDetect in benchmark setup (authored by Pieter Wuille <pieter@wuille.net>, committed by PiRK). · Explain WhySep 1 2021, 12:02

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC4d0d32567acc: Call SHA256AutoDetect in benchmark setup.

Revision Contents
Changeset List

Path

Size

src/

bench/

bench_bitcoin.cpp

2 lines

Diff 29724

View Options

src/bench/bench_bitcoin.cpp

Call SHA256AutoDetect in benchmark setupClosedPublicActions