Page MenuHomePhabricator

Add TX_INPUTS_NOT_STANDARD to TxValidationResult
ClosedPublic

Authored by PiRK on Tue, Sep 7, 09:56.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC74b9af263eda: Add TX_INPUTS_NOT_STANDARD to TxValidationResult
Summary

Nothing in the PR's description is relevant to use, but having a special subcategory of TX_NOT_STANDARD for non-standard inputs seems reasonable.

Our codebase already adds those txid to the recentRejectFilter, so most of the changes do not apply.

This is a backport of core#19620

https://github.com/bitcoin/bitcoin/pull/19620/commits/7989901c7eb62ca28b3d1e5d5831041a7267e495

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Tue, Sep 7, 09:56
Fabien requested changes to this revision.Thu, Sep 9, 07:25
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/consensus/validation.h
29 ↗(On Diff #29831)

The comment update is missing here

This revision now requires changes to proceed.Thu, Sep 9, 07:25

update TX_NOT_STANDARD comment

This revision is now accepted and ready to land.Thu, Sep 9, 13:25