Page MenuHomePhabricator
Differential D10061

Add TX_INPUTS_NOT_STANDARD to TxValidationResult
ClosedPublic
Actions

Authored by PiRK on Sep 7 2021, 09:56.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC74b9af263eda: Add TX_INPUTS_NOT_STANDARD to TxValidationResult
Summary

Nothing in the PR's description is relevant to use, but having a special subcategory of TX_NOT_STANDARD for non-standard inputs seems reasonable.

Our codebase already adds those txid to the recentRejectFilter, so most of the changes do not apply.

This is a backport of core#19620

https://github.com/bitcoin/bitcoin/pull/19620/commits/7989901c7eb62ca28b3d1e5d5831041a7267e495

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 7 2021, 09:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 7 2021, 09:56
PiRK requested review of this revision.Sep 7 2021, 09:56
teamcity edited the summary of this revision. (Show Details)Sep 7 2021, 09:56
Harbormaster completed remote builds in B16575: Diff 29831.Sep 7 2021, 10:10
PiRK edited the summary of this revision. (Show Details)Sep 7 2021, 15:20
Fabien requested changes to this revision.Sep 9 2021, 07:25
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/consensus/validation.h
29 ↗(On Diff #29831)

The comment update is missing here

This revision now requires changes to proceed.Sep 9 2021, 07:25
PiRK updated this revision to Diff 29866.Sep 9 2021, 08:39

update TX_NOT_STANDARD comment

Harbormaster completed remote builds in B16595: Diff 29866.Sep 9 2021, 08:54
Fabien accepted this revision.Sep 9 2021, 13:25
This revision is now accepted and ready to land.Sep 9 2021, 13:25
Closed by commit rABC74b9af263eda: Add TX_INPUTS_NOT_STANDARD to TxValidationResult (authored by Suhas Daftuar <sdaftuar@gmail.com>, committed by PiRK). · Explain WhySep 9 2021, 13:53
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC74b9af263eda: Add TX_INPUTS_NOT_STANDARD to TxValidationResult.

Revision Contents
Changeset List

PathSize
src/
consensus/
4 lines
1 line
2 lines

Diff 29882

View Options

src/consensus/validation.h

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/validation.cpp

Loading...