Page MenuHomePhabricator
Differential D10093

[Cashtab] Ignore tx history for large-input txs
ClosedPublic
Actions

Authored by bytesofman on Sep 13 2021, 13:10.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC0c069e0070f3: [Cashtab] Ignore tx history for large-input txs
Summary

T1824

The`BCH.RawTransactions.getTxData(txid) function from bch-js` chokes on transactions with a large amount of inputs. In this case, it returns undefined instead of an object.

This means that if your wallet has such a tx in the last 5 txs, it will always through an API rate limit error, making Cashtab impossible to use.

This diff catches such cases and omits them from the tx history.

This fix prevents the wallet crash error. However, a more permanent way to deal with this would be to improve the function in bch-js.

Test Plan
  1. DM me for a recovery seed of a wallet with such a transaction
  2. Import the wallet.
  3. Note that it loads with < 5 txs in history but does not instantly rate limit.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Sep 13 2021, 13:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 13 2021, 13:10
bytesofman requested review of this revision.Sep 13 2021, 13:10
bytesofman updated this revision to Diff 29901.

Removing line break irrelevant to this diff

Harbormaster completed remote builds in B16614: Diff 29900.Sep 13 2021, 13:13
Harbormaster completed remote builds in B16615: Diff 29901.
bytesofman updated this revision to Diff 29902.Sep 13 2021, 13:59

Instead of removing txs, replace with empty box that links to explorer

Harbormaster completed remote builds in B16616: Diff 29902.Sep 13 2021, 14:02
Fabien accepted this revision.Sep 13 2021, 14:04
This revision is now accepted and ready to land.Sep 13 2021, 14:04
Closed by commit rABC0c069e0070f3: [Cashtab] Ignore tx history for large-input txs (authored by Joey King <joseph.roy.king@gmail.com>). · Explain WhySep 13 2021, 14:05
This revision was automatically updated to reflect the committed changes.
Joey King <joseph.roy.king@gmail.com> added a commit: rABC0c069e0070f3: [Cashtab] Ignore tx history for large-input txs.

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
components/
Wallet/
321 lines
__tests__/
__snapshots__/
hooks/
33 lines

Diff 29903

View Options

web/cashtab/src/components/Wallet/Tx.js

Loading...
View Options

web/cashtab/src/components/Wallet/__tests__/__snapshots__/Wallet.test.js.snap

Loading...
View Options

web/cashtab/src/hooks/useBCH.js

Loading...