Page MenuHomePhabricator

[avalanche] Improve invalid-signature error message accuracy
ClosedPublic

Authored by Fabien on Mon, Sep 13, 15:29.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABCf82652601c8c: [avalanche] Improve invalid-signature error message accuracy
Summary

This error relates to an invalid stake signature, so use that. This will make it easier to distiguish the error when we introduce proof signature.

Ref T1676.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Mon, Sep 13, 15:29
This revision is now accepted and ready to land.Mon, Sep 13, 15:35

Failed tests logs:

====== Bitcoin ABC functional tests: p2p_blockfilters.py ======

------- Stdout: -------
2021-09-13T15:35:23.054000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210913_153332/p2p_blockfilters_28
2021-09-13T15:35:27.501000Z TestFramework (INFO): get cfcheckpt on chain to be re-orged out.
2021-09-13T15:35:27.551000Z TestFramework (INFO): Reorg node 0 to a new chain.
2021-09-13T15:35:30.039000Z TestFramework (INFO): Check that peers can fetch cfcheckpt on active chain.
2021-09-13T15:35:30.089000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 128, in main
    self.run_test()
  File "/work/test/functional/p2p_blockfilters.py", line 115, in run_test
    assert_equal(response.stop_hash, request.stop_hash)
  File "/work/test/functional/test_framework/util.py", line 60, in assert_equal
    for arg in (thing1, thing2) + args)))
AssertionError: not(29208245511508020290502706100409943912691741487524093289432462394150357675791 == 39233330885284764873765017399512655931914796578074666857825055159411215259920)
2021-09-13T15:35:30.140000Z TestFramework (INFO): Stopping nodes
2021-09-13T15:35:30.392000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210913_153332/p2p_blockfilters_28
2021-09-13T15:35:30.392000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210913_153332/p2p_blockfilters_28/test_framework.log
2021-09-13T15:35:30.393000Z TestFramework (ERROR): 
2021-09-13T15:35:30.393000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210913_153332/p2p_blockfilters_28' to consolidate all logs
2021-09-13T15:35:30.393000Z TestFramework (ERROR): 
2021-09-13T15:35:30.393000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2021-09-13T15:35:30.393000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2021-09-13T15:35:30.393000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: p2p_blockfilters.py

This revision was landed with ongoing or failed builds.Mon, Sep 13, 19:17
This revision was automatically updated to reflect the committed changes.