test: Remove unused classes from p2p_leak.py
ClosedPublic
Actions

Authored by PiRK on Sep 15 2021, 08:26.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC5e48e99a4b34: test: Remove unused classes from p2p_leak.py

Summary

test: remove CNodeNoVersionMisbehavior from p2p_leak.py

It's also clearer to have no_version_disconnect_node send a message
other than version or verack in order to reach the peer discouragement
threshold.

test: remove CNodeNoVersionIdle from p2p_leak.py

test: Distinguish between nodes(bitcoind) and peers(mininodes) in p2p_leak.py

Also, remove "C" prefix from class names to match new style

This is a backport of core#19727

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 15 2021, 08:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 15 2021, 08:26

PiRK requested review of this revision.Sep 15 2021, 08:26

teamcity edited the summary of this revision. (Show Details)Sep 15 2021, 08:26

Harbormaster completed remote builds in B16652: Diff 29968.Sep 15 2021, 08:41

Fabien accepted this revision.Sep 15 2021, 13:47

This revision is now accepted and ready to land.Sep 15 2021, 13:47

Closed by commit rABC5e48e99a4b34: test: Remove unused classes from p2p_leak.py (authored by Dhruv Mehta <856960+dhruv@users.noreply.github.com>, committed by PiRK). · Explain WhySep 15 2021, 17:03

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC5e48e99a4b34: test: Remove unused classes from p2p_leak.py.

Revision Contents
Changeset List

Path

Size

test/

functional/

p2p_leak.py

89 lines

Diff 29978

View Options

test/functional/p2p_leak.py

test: Remove unused classes from p2p_leak.pyClosedPublicActions