Page MenuHomePhabricator
Differential D10120

[test] Add test for getblockheader verboseness
ClosedPublic
Actions

Authored by PiRK on Sep 15 2021, 09:05.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCc7152f710ca1: [test] Add test for getblockheader verboseness
Summary

Add test for getblockheader with verbose argument set to false.

This is a backport of core#19722

Test Plan

ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 15 2021, 09:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 15 2021, 09:05
PiRK requested review of this revision.Sep 15 2021, 09:05
teamcity edited the summary of this revision. (Show Details)Sep 15 2021, 09:05
Harbormaster completed remote builds in B16655: Diff 29971.Sep 15 2021, 09:21
Fabien requested changes to this revision.Sep 15 2021, 14:01
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/rpc_blockchain.py
33 ↗(On Diff #29971)

Fix ordering. I thought the linter would catch this ?

This revision now requires changes to proceed.Sep 15 2021, 14:01
PiRK updated this revision to Diff 29973.Sep 15 2021, 14:35

fix import ordering

Harbormaster completed remote builds in B16657: Diff 29973.Sep 15 2021, 14:49
PiRK added a comment.Sep 15 2021, 17:06

I will wait for D10124 to land before rebasing and landing this.

Fabien accepted this revision.Sep 15 2021, 19:24

No need to wait for anything before landing

This revision is now accepted and ready to land.Sep 15 2021, 19:24
Closed by commit rABCc7152f710ca1: [test] Add test for getblockheader verboseness (authored by Torhte Butler <torhte@protonmail.com>, committed by PiRK). · Explain WhySep 16 2021, 04:58
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCc7152f710ca1: [test] Add test for getblockheader verboseness.

Revision Contents
Changeset List

PathSize
test/
functional/
10 lines

Diff 29985

View Options

test/functional/rpc_blockchain.py

Loading...