Paths

Table of Contentst

Differential D10128

test: Update wait_until usage in tests not to use the one from utils
ClosedPublic
Actions

Authored by PiRK on Sep 16 2021, 11:39.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC914e834144d0: test: Update wait_until usage in tests not to use the one from utils

Summary

Using the global wait_until makes it impossible to adjust the timeout based on the hardware the test is running on.

test: Update wait_until usage in tests not to use the one from utils

Replace "wait_until()" usage from utils, with the ones from BitcoinTestFramework and P2PInterface.
closes #19080

test: Add docstring to wait_until() in util.py to warn about its usage

This is a backport of core#19752

Test Plan

ninja check-functional-extended

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 16 2021, 11:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 16 2021, 11:39

PiRK requested review of this revision.Sep 16 2021, 11:39

teamcity edited the summary of this revision. (Show Details)Sep 16 2021, 11:39

Harbormaster completed remote builds in B16669: Diff 29991.Sep 16 2021, 11:54

The PR number is wrong

This revision now requires changes to proceed.Sep 16 2021, 12:15

Thanks. I fixed the description.

Btw, I just noticed that I forgot the abc_* tests. I will change them in a separate revision, because this is already very large to review.

PiRK requested review of this revision.Sep 16 2021, 12:43

PiRK mentioned this in D10132: test: Update wait_until usage in abc tests not to use the one from utils.Sep 16 2021, 13:01

Fabien accepted this revision.Sep 16 2021, 13:32

This revision is now accepted and ready to land.Sep 16 2021, 13:32

Closed by commit rABC914e834144d0: test: Update wait_until usage in tests not to use the one from utils (authored by Seleme Topuz <seleme94@hotmail.com>, committed by PiRK). · Explain WhySep 16 2021, 14:29

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC914e834144d0: test: Update wait_until usage in tests not to use the one from utils.

PiRK mentioned this in rABCa564bcdcd80a: test: Update wait_until usage in abc tests not to use the one from utils.

Revision Contents
Changeset List

Path

Size

test/

functional/

example_test.py

7 lines

feature_abortnode.py

4 lines

feature_notifications.py

24 lines

11 lines

6 lines

3 lines

5 lines

51 lines

p2p_disconnect_ban.py

10 lines

p2p_eviction.py

5 lines

p2p_feefilter.py

3 lines

p2p_fingerprint.py

10 lines

p2p_invalid_messages.py

6 lines

p2p_invalid_tx.py

4 lines

p2p_leak.py

11 lines

p2p_node_network_limited.py

8 lines

p2p_permissions.py

3 lines

p2p_sendheaders.py

10 lines

rpc_invalidateblock.py

7 lines

rpc_net.py

13 lines

test_framework/

util.py

8 lines

wallet_resendwallettransactions.py

16 lines

wallet_zapwallettxes.py

5 lines

Diff 30002

View Options

test/functional/example_test.py

View Options

test/functional/feature_abortnode.py

View Options

test/functional/feature_notifications.py

View Options

test/functional/feature_pruning.py

View Options

test/functional/feature_shutdown.py

View Options

test/functional/mempool_persist.py

View Options

test/functional/p2p_blockfilters.py

View Options

test/functional/p2p_compactblocks.py

View Options

test/functional/p2p_disconnect_ban.py

View Options

test/functional/p2p_eviction.py

View Options

test/functional/p2p_feefilter.py

View Options

test/functional/p2p_fingerprint.py

View Options

test/functional/p2p_invalid_messages.py

View Options

test/functional/p2p_invalid_tx.py

View Options

test/functional/p2p_leak.py

View Options

test/functional/p2p_node_network_limited.py

View Options

test/functional/p2p_permissions.py

View Options

test/functional/p2p_sendheaders.py

View Options

test/functional/rpc_invalidateblock.py

View Options

test/functional/rpc_net.py

View Options

test/functional/test_framework/util.py

View Options

test/functional/wallet_resendwallettransactions.py

View Options

test/functional/wallet_zapwallettxes.py

test: Update wait_until usage in tests not to use the one from utilsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 30002

test/functional/example_test.py

test/functional/feature_abortnode.py

test/functional/feature_notifications.py

test/functional/feature_pruning.py

test/functional/feature_shutdown.py

test/functional/mempool_persist.py

test/functional/p2p_blockfilters.py

test/functional/p2p_compactblocks.py

test/functional/p2p_disconnect_ban.py

test/functional/p2p_eviction.py

test/functional/p2p_feefilter.py

test/functional/p2p_fingerprint.py

test/functional/p2p_invalid_messages.py

test/functional/p2p_invalid_tx.py

test/functional/p2p_leak.py

test/functional/p2p_node_network_limited.py

test/functional/p2p_permissions.py

test/functional/p2p_sendheaders.py

test/functional/rpc_invalidateblock.py

test/functional/rpc_net.py

test/functional/test_framework/util.py

test/functional/wallet_resendwallettransactions.py

test/functional/wallet_zapwallettxes.py

test: Update wait_until usage in tests not to use the one from utils
ClosedPublic
Actions

Revision Contents
Changeset List