rpc: Validate provided keys for query_options parameter in listunspent
ClosedPublic
Actions

Authored by PiRK on Sep 16 2021, 11:56.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC7d31c1813b78: rpc: Validate provided keys for query_options parameter in listunspent

Summary

With this change listunspent will throw an error if there is a wrong key
in the query_option object.

Signed-off-by: pasta <pasta@dashboost.org>

Comment by @MarcoFalke:

RPCman will do this in the future, but nothing wrong adding something like that in the meantime

This is a backport of core#19169

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 16 2021, 11:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 16 2021, 11:56

PiRK requested review of this revision.Sep 16 2021, 11:56

teamcity edited the summary of this revision. (Show Details)Sep 16 2021, 11:56

Harbormaster completed remote builds in B16670: Diff 29992.Sep 16 2021, 12:10

Fabien accepted this revision.Sep 16 2021, 12:17

This revision is now accepted and ready to land.Sep 16 2021, 12:17

Closed by commit rABC7d31c1813b78: rpc: Validate provided keys for query_options parameter in listunspent (authored by pasta <pasta@dashboost.org>, committed by PiRK). · Explain WhySep 16 2021, 13:23

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC7d31c1813b78: rpc: Validate provided keys for query_options parameter in listunspent.

Revision Contents
Changeset List

Path

Size

src/

wallet/

rpcwallet.cpp

9 lines

Diff 29998

View Options

rpc: Validate provided keys for query_options parameter in listunspentClosedPublicActions