Remove old check for 3-byte shifted IP addresses from pre-0.2.9 node messages
ClosedPublic
Actions

Authored by PiRK on Sep 16 2021, 13:27.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCf13fc65c5739: Remove old check for 3-byte shifted IP addresses from pre-0.2.9 node messages

Summary

The change removes an old check for IPv6 addresses in range ::ff:ff00:0:0:0/72 that were created due to a bug in size field of addr messages for 0.2.8 nodes and before.

This check is no longer needed as they are no more pre 0.2.9 nodes on the network (as per bitnodes network snapshot).

Credits for discovering this go to sipa.

This is a backport of core#19797

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 16 2021, 13:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 16 2021, 13:27

PiRK requested review of this revision.Sep 16 2021, 13:27

teamcity edited the summary of this revision. (Show Details)Sep 16 2021, 13:27

Harbormaster completed remote builds in B16675: Diff 30001.Sep 16 2021, 13:58

Fabien accepted this revision.Sep 16 2021, 20:15

This revision is now accepted and ready to land.Sep 16 2021, 20:15

Closed by commit rABCf13fc65c5739: Remove old check for 3-byte shifted IP addresses from pre-0.2.9 node messages (authored by Raúl Martínez (RME) <i-rme@users.noreply.github.com>, committed by PiRK). · Explain WhySep 17 2021, 06:09

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCf13fc65c5739: Remove old check for 3-byte shifted IP addresses from pre-0.2.9 node messages.

Revision Contents
Changeset List

Path

Size

src/

netaddress.cpp

11 lines

Diff 30014

View Options

Remove old check for 3-byte shifted IP addresses from pre-0.2.9 node messagesClosedPublicActions