Avoid locking CTxMemPool::cs recursively in simple cases
ClosedPublic
Actions

Authored by PiRK on Sep 22 2021, 09:15.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCee5de8785e21: Avoid locking CTxMemPool::cs recursively in simple cases

Summary

Only trivial thread safety annotations and lock assertions added. No new locks.
No change in behavior, the lock is already held at call sites.

This is a backport of core#19854

Test Plan

With TSAN:
ninja && ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 22 2021, 09:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 22 2021, 09:15

PiRK requested review of this revision.Sep 22 2021, 09:15

teamcity edited the summary of this revision. (Show Details)Sep 22 2021, 09:15

Harbormaster completed remote builds in B16749: Diff 30114.Sep 22 2021, 09:30

Fabien accepted this revision.Sep 22 2021, 12:15

This revision is now accepted and ready to land.Sep 22 2021, 12:15

Closed by commit rABCee5de8785e21: Avoid locking CTxMemPool::cs recursively in simple cases (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhySep 22 2021, 12:52

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCee5de8785e21: Avoid locking CTxMemPool::cs recursively in simple cases.

Revision Contents
Changeset List

Path

Size

src/

txmempool.h

19 lines

txmempool.cpp

6 lines

Diff 30123

View Options

src/txmempool.h