Page MenuHomePhabricator

test: Fix flaky wallet_basic test
ClosedPublic

Authored by PiRK on Sep 22 2021, 12:51.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC314bdf8203d8: test: Fix flaky wallet_basic test
Summary

I investigated the issue in core#19876 and I still intend to fix the underlying issue of a race when using wallet RPCs right after starting a node in that PR. However, since that is a bit more complicated than I initially thought it makes sense to merge the fix of the test so the intermittent test failures stop. This fix in the test is going to be needed, either way, #19876 will only provide an error where before it was reporting a false balance

Co-authored-by: João Barbosa <joao.paulo.barbosa@gmail.com>

This is a backport of core#19887

Test Plan

ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Sep 22 2021, 12:51
Fabien edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Sep 22 2021, 15:46
This revision was automatically updated to reflect the committed changes.