[avalanche] Explicitely set the legacy format where expected
ClosedPublic
Actions

Authored by Fabien on Sep 28 2021, 20:03.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABCb9faa755ae66: [avalanche] Explicitely set the legacy format where expected

Summary

The proof deserialization test uses 2 vectors: one for legacy format and one for the new format. But the test only sets the -legacyavaproof flag for the latter, making the test brittle.

Ref T1676.

Test Plan

ninja check-avalanche-proof_tests

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Sep 28 2021, 20:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 28 2021, 20:03

Fabien requested review of this revision.Sep 28 2021, 20:03

Harbormaster completed remote builds in B16802: Diff 30192.Sep 28 2021, 20:18

deadalnix accepted this revision.Sep 29 2021, 01:22

This revision is now accepted and ready to land.Sep 29 2021, 01:22

Closed by commit rABCb9faa755ae66: [avalanche] Explicitely set the legacy format where expected (authored by Fabien). · Explain WhySep 29 2021, 08:02

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCb9faa755ae66: [avalanche] Explicitely set the legacy format where expected.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

test/

proof_tests.cpp

3 lines

Diff 30199

View Options

src/avalanche/test/proof_tests.cpp

[avalanche] Explicitely set the legacy format where expectedClosedPublicActions