Page MenuHomePhabricator

Add jsconfig to allow navigate alias easier in vscode
Needs RevisionPublic

Authored by vince8x on Oct 1 2021, 01:46.

Details

Reviewers
bytesofman
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

Currently it's difficult for vscode user to navigate the imports with alias
The commit add jsconfig file to cashtab to allow user navigate the code easier

Test Plan
  • Open the project with vscode
  • Click on any import with alias syntax to see the navigation work

Diff Detail

Repository
rABC Bitcoin ABC
Branch
navigate-alias-vs-code
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16850
Build 33540: Build Diffcashtab-tests
Build 33539: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Oct 1 2021, 01:46
vince8x requested review of this revision.Oct 1 2021, 01:46

Tail of the build log:

/work/web/cashtab /work/abc-ci-builds/cashtab-tests

added 2752 packages, and audited 2753 packages in 44s

150 packages are looking for funding
  run `npm fund` for details

17 vulnerabilities (15 moderate, 2 high)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.
npm notice 
npm notice New minor version of npm available! 7.7.6 -> 7.24.1
npm notice Changelog: <https://github.com/npm/cli/releases/tag/v7.24.1>
npm notice Run `npm install -g npm@7.24.1` to update!
npm notice 

> cashtab@1.0.0 build
> node scripts/build.js

/work/web/cashtab/config/modules.js:42
    throw new Error(
    ^

Error: Your project's `baseUrl` can only be set to `src` or `node_modules`. Create React App does not support other values at this time.
    at getAdditionalModulePaths (/work/web/cashtab/config/modules.js:42:11)
    at getModules (/work/web/cashtab/config/modules.js:80:35)
    at Object.<anonymous> (/work/web/cashtab/config/modules.js:88:18)
    at Module._compile (node:internal/modules/cjs/loader:1092:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1121:10)
    at Module.load (node:internal/modules/cjs/loader:972:32)
    at Function.Module._load (node:internal/modules/cjs/loader:813:14)
    at Module.require (node:internal/modules/cjs/loader:996:19)
    at require (node:internal/modules/cjs/helpers:92:18)
    at Object.<anonymous> (/work/web/cashtab/config/webpack.config.js:23:17)
Build cashtab-tests failed with exit code 1

Fix incorrect baseUrl in jsconfig.json

Fabien requested changes to this revision.Oct 1 2021, 08:21
Fabien added a subscriber: Fabien.

Thanks for the patch, but committing IDE specific files to the repository should be avoided. Each user has its own favorite, and in the end we will get a lot of unmaintained files that will cause more confusion than help.
You can still add this file to your local repo by following the guidelines from the developer notes: https://github.com/Bitcoin-ABC/bitcoin-abc/blob/master/doc/developer-notes.md#ignoring-ideeditor-files

This revision now requires changes to proceed.Oct 1 2021, 08:21

Thanks for your review. Please help to close the PR. I'll be more careful next time.