[Cashtab] Add domain migration alert pop-up
ClosedPublic
Actions

Authored by bytesofman on Oct 4 2021, 21:08.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCf11c05c30b84: [Cashtab] Add domain migration alert pop-up

Summary

T1892

Cashtab will migrate from cashtabapp.com to cashtab.com

Local storage works by domain name, so this migration will require users to manually import their wallets at the new domain. This is annoying and bad UX, but will only get worse the longer the move is postponed.

The migration will happen in phases.

[Oct 2021] Users at cashtabapp.com see a pop-up informing them of the domain migration. Click makes the pop-up go away. App functionality is otherwise normal.
[Nov 2021] Users at cashtabapp.com see a pop-up informing them of the domain migration. The notification will re-open every 30s if it is closed. This will allow users to recover private keys at the old domain.
[Dec 2021-Dec2022] Users at cashtabapp.com see a pop-up informing them of the migration. The page will auto-fwd to cashtab.com after 30s

This diff allows the migration to happen without supporting two different codebases for each domain. For now, currency.appUrl is set to cashtabapp.com, so the expected behavior of this diff is to do nothing. I will point cashtab.com to the deployment server, then put up another diff changing currency.appUrl to cashtab.com

Test Plan

npm start
Note pop-up on load
In src/components/Common/Ticker.js, change currency.appUrl to localhost
Note pop-up does not appear on load (expected behavior when this diff is landed with currency.appUrl as cashtabapp.com)

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Oct 4 2021, 21:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 4 2021, 21:08

bytesofman requested review of this revision.Oct 4 2021, 21:08

Harbormaster completed remote builds in B16876: Diff 30296.Oct 4 2021, 21:34

Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Tail of the build log:

/work/web/cashtab /work/abc-ci-builds/cashtab-tests
npm notice 
npm notice New minor version of npm available! 7.7.6 -> 7.24.2
npm notice Changelog: <https://github.com/npm/cli/releases/tag/v7.24.2>
npm notice Run `npm install -g npm@7.24.2` to update!
npm notice 
npm ERR! code ERR_SOCKET_TIMEOUT
npm ERR! errno ERR_SOCKET_TIMEOUT
npm ERR! request to https://registry.npmjs.org/@typescript-eslint%2feslint-plugin failed, reason: Socket timeout

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2021-10-04T21_34_21_026Z-debug.log
Build cashtab-tests failed with exit code 1

Reduce console.log statements; repush to rebuild teamcity tests

Harbormaster completed remote builds in B16883: Diff 30315.Oct 5 2021, 11:40

PiRK accepted this revision.Oct 6 2021, 07:13

This revision is now accepted and ready to land.Oct 6 2021, 07:13

Closed by commit rABCf11c05c30b84: [Cashtab] Add domain migration alert pop-up (authored by Joey King <joseph.roy.king@gmail.com>). · Explain WhyOct 6 2021, 17:52

This revision was automatically updated to reflect the committed changes.

Joey King <joseph.roy.king@gmail.com> added a commit: rABCf11c05c30b84: [Cashtab] Add domain migration alert pop-up.