Page MenuHomePhabricator

use the correct rounding in assert_fee_amount
ClosedPublic

Authored by PiRK on Wed, Oct 6, 12:36.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC9476c912c0b7: use the correct rounding in assert_fee_amount
Summary

The rounding was introduced in D3516 for a good reason (making it easier to troubleshoot failing tests). But after changing the unit to XEC in the tests, the benefits were lost because it was still round to 8 decimal places.

Using satoshi_round instead of switching from round(..., 8) to round(..., 2) makes the intent more clear.

Test Plan

ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable