Page MenuHomePhabricator
Differential D10288

test: add parameterized constructor for msg_sendcmpct()
ClosedPublic
Actions

Authored by PiRK on Oct 8 2021, 13:22.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCe13ecc8c665b: test: add parameterized constructor for msg_sendcmpct()
Summary

This is a backport of core#19781

Test Plan

ninja check-functional-extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 8 2021, 13:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 8 2021, 13:22
PiRK requested review of this revision.Oct 8 2021, 13:22
teamcity edited the summary of this revision. (Show Details)Oct 8 2021, 13:22
Harbormaster completed remote builds in B16941: Diff 30391.Oct 8 2021, 13:32
Fabien requested changes to this revision.Oct 8 2021, 19:35
Fabien added a subscriber: Fabien.

Please use this consistently in all tests

This revision now requires changes to proceed.Oct 8 2021, 19:35
PiRK updated this revision to Diff 30407.Oct 11 2021, 07:23

apply change also in abc_p2p_compactblocks

Harbormaster completed remote builds in B16951: Diff 30407.Oct 11 2021, 07:53
Fabien requested changes to this revision.Oct 11 2021, 13:11

You need to run the test as part of the test plan, it's in the extended tests

This revision now requires changes to proceed.Oct 11 2021, 13:11
PiRK edited the test plan for this revision. (Show Details)Oct 11 2021, 18:23
PiRK requested review of this revision.Oct 11 2021, 18:56

Test plan updated. I used the wrong vi macro to write it.

Fabien accepted this revision.Oct 12 2021, 08:23
This revision is now accepted and ready to land.Oct 12 2021, 08:23
Closed by commit rABCe13ecc8c665b: test: add parameterized constructor for msg_sendcmpct() (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>, committed by PiRK). · Explain WhyOct 12 2021, 13:15
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCe13ecc8c665b: test: add parameterized constructor for msg_sendcmpct().

Revision Contents
Changeset List

PathSize
test/
functional/
5 lines
35 lines
test_framework/
6 lines

Diff 30463

View Options

test/functional/abc_p2p_compactblocks.py

Loading...
View Options

test/functional/p2p_compactblocks.py

Loading...
View Options

test/functional/test_framework/messages.py

Loading...