Page MenuHomePhabricator

test: add parameterized constructor for msg_sendcmpct()
ClosedPublic

Authored by PiRK on Fri, Oct 8, 13:22.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCe13ecc8c665b: test: add parameterized constructor for msg_sendcmpct()
Summary

This is a backport of core#19781

Test Plan

ninja check-functional-extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Fri, Oct 8, 13:22
Fabien requested changes to this revision.Fri, Oct 8, 19:35
Fabien added a subscriber: Fabien.

Please use this consistently in all tests

This revision now requires changes to proceed.Fri, Oct 8, 19:35

apply change also in abc_p2p_compactblocks

Fabien requested changes to this revision.Mon, Oct 11, 13:11

You need to run the test as part of the test plan, it's in the extended tests

This revision now requires changes to proceed.Mon, Oct 11, 13:11
PiRK requested review of this revision.Mon, Oct 11, 18:56

Test plan updated. I used the wrong vi macro to write it.

This revision is now accepted and ready to land.Tue, Oct 12, 08:23