Page MenuHomePhabricator
Differential D10299

Assert that RPCArg names are equal to CRPCCommand ones (rawtransaction)
ClosedPublic
Actions

Authored by PiRK on Oct 11 2021, 12:56.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCd9ac1af5e4be: Assert that RPCArg names are equal to CRPCCommand ones (rawtransaction)
Summary

This is a backport of core#19849 [2/2]
https://github.com/bitcoin/bitcoin/pull/19849/commits/fa6bb0ce5dba33970e2c1e47ea4d0d2c0718eccb

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 11 2021, 12:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 11 2021, 12:56
PiRK requested review of this revision.Oct 11 2021, 12:56
teamcity edited the summary of this revision. (Show Details)Oct 11 2021, 12:56
Harbormaster completed remote builds in B16955: Diff 30417.Oct 11 2021, 13:18
Fabien edited the summary of this revision. (Show Details)Oct 11 2021, 13:30
Fabien requested changes to this revision.Oct 11 2021, 13:33
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/rpc/rawtransaction.cpp
251 ↗(On Diff #30417)

layout

255 ↗(On Diff #30417)

dito

This revision now requires changes to proceed.Oct 11 2021, 13:33
PiRK updated this revision to Diff 30423.Oct 11 2021, 19:00
PiRK edited the summary of this revision. (Show Details)

string layout

Harbormaster completed remote builds in B16960: Diff 30423.Oct 11 2021, 19:11
Fabien accepted this revision.Oct 12 2021, 08:28
This revision is now accepted and ready to land.Oct 12 2021, 08:28
Closed by commit rABCd9ac1af5e4be: Assert that RPCArg names are equal to CRPCCommand ones (rawtransaction) (authored by PiRK). · Explain WhyOct 12 2021, 13:18
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCd9ac1af5e4be: Assert that RPCArg names are equal to CRPCCommand ones (rawtransaction).

Revision Contents
Changeset List

PathSize
src/
rpc/
1988 lines

Diff 30464

View Options

src/rpc/rawtransaction.cpp

Loading...