Page MenuHomePhabricator

fix a flake8 vs autopep8 interference
ClosedPublic

Authored by PiRK on Thu, Oct 14, 07:24.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCf6739909c8f2: fix a flake8 vs autopep8 interference
Summary

flake8 and autopep8 both detect 'Too many blank lines (E303)' and 'Expected 2 blank lines after end of function or class (E305)' style errors. This causes autopep8 to ask if the autofix should be applied instead of applying it directly, and the flake8 errors will be reported anyway on phabricator as false positives even though it was fixed (if the linting happens as part of the arc diff command).

Making flake8 ignore those errors fixes this issue. Autopep8 will apply the autofix without prompting the user.

Test Plan

Remove a blank line after a class or function, and add an extra blank line between two functions in a python file. Run arc lint, and verify that it is fixed automatically.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable