Differential D10365

[avalanche] Don't reserve a slot for block voting
ClosedPublic
Actions

Authored by Fabien on Oct 18 2021, 08:24.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABC5af61d0bada7: [avalanche] Don't reserve a slot for block voting

Summary

This was intended to be a DoS mitigation but is no longer required.

Ref T1854.

Test Plan

ninja check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 18 2021, 08:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 18 2021, 08:24

Fabien requested review of this revision.Oct 18 2021, 08:25

Fabien mentioned this in D10327: [avalanche] Refactor the vote records to inv extraction loop.Oct 18 2021, 08:30

Fabien added a child revision: D10327: [avalanche] Refactor the vote records to inv extraction loop.Oct 18 2021, 08:30

Harbormaster completed remote builds in B17060: Diff 30594.Oct 18 2021, 08:39

deadalnix accepted this revision.Oct 18 2021, 18:07

This revision is now accepted and ready to land.Oct 18 2021, 18:07

Closed by commit rABC5af61d0bada7: [avalanche] Don't reserve a slot for block voting (authored by Fabien). · Explain WhyOct 18 2021, 19:06

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC5af61d0bada7: [avalanche] Don't reserve a slot for block voting.

Fabien removed a child revision: D10327: [avalanche] Refactor the vote records to inv extraction loop.Oct 18 2021, 20:19

Revision Contents
Changeset List

Path

Size

src/

avalanche/

processor.cpp

6 lines

test/

processor_tests.cpp

6 lines

Diff 30600

View Options

src/avalanche/processor.cpp