Page MenuHomePhabricator
Differential D10385

[avalanche] Check that a UTXO has not been reassigned before erasing it
AbandonedPublic
Actions

Authored by Fabien on Oct 22 2021, 13:09.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

This diff adds a safety check that prevents from erasing an UTXO that would have been reassigned to another peer. This is currently not possible but will be used when managing conflicting proofs in the peer manager. Also it makes the code more robust anyway, so it's worth it even without conflicting proofs.

Ret T1854.

Test Plan
ninja all check-all

Diff Detail

Event Timeline

Fabien created this revision.Oct 22 2021, 13:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 22 2021, 13:09
Fabien requested review of this revision.Oct 22 2021, 13:09
Harbormaster completed remote builds in B17110: Diff 30652.Oct 22 2021, 13:28
deadalnix requested changes to this revision.Oct 27 2021, 14:25
deadalnix added a subscriber: deadalnix.

I don't think this makes any sense. If there is a concurrency problem, then the right way to solve it is to use locks. Right now, we don't do concurency within the peer manager, so no lock needed.

This revision now requires changes to proceed.Oct 27 2021, 14:25
Fabien abandoned this revision.Oct 28 2021, 12:19

This is a premature optimization, leave it for now

Revision Contents
Changeset List

PathSize
src/
avalanche/
8 lines

Diff 30652

View Options

src/avalanche/peermanager.cpp

Loading...