Differential D10394

[avalanche] Accept the conflicting proofs if they are preferred
AbandonedPublic
Actions

Authored by Fabien on Oct 28 2021, 14:15.

Tags

None

Subscribers

None

Details

Reviewers

None

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Summary

This diff lets the peer manager accept conflicting proofs that are preferred over all the existing ones, which ends up orphaned. This feature is disabled by default and hidden behind an opiont switch so the behavior is unchanged by default.

Ref T1854.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_peermanager_accept_conflicting_proof

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17127
Build 34086: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 34085: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 28 2021, 14:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 28 2021, 14:15

Fabien requested review of this revision.Oct 28 2021, 14:15

Fabien added a child revision: D10395: [avalanche] Store the conflicting proofs.Oct 28 2021, 14:29

Harbormaster completed remote builds in B17127: Diff 30683.Oct 28 2021, 14:30

Fabien added a child revision: D10404: [avalanche] Make `isConflictingProofPreferred` a static function.Oct 29 2021, 10:25

Fabien planned changes to this revision.Nov 4 2021, 09:39

Fabien abandoned this revision.Dec 14 2021, 15:58

Revision Contents
Changeset List

Path

Size

src/

avalanche/

9 lines

peermanager.cpp

40 lines

test/

peermanager_tests.cpp

141 lines

5 lines

test/

functional/

abc_rpc_avalancheproof.py

2 lines

Diff 30683

src/avalanche/peermanager.h

Loading...

src/avalanche/peermanager.cpp

Loading...

src/avalanche/test/peermanager_tests.cpp

Loading...

src/init.cpp

Loading...

test/functional/abc_rpc_avalancheproof.py

Loading...