Page MenuHomePhabricator

rebrand the address widget in bitcoin-qt
Changes PlannedPublic

Authored by PiRK on Oct 29 2021, 10:17.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Summary

This placeholder text is displayed in several places in the GUI: in the send tab, in the "Sign message" dialog, in the "Verify message dialog".

Test Plan

ninja && src/qt/bitcoin-qt

Check the placeholder text in the widgets that are designed for pasting an address (send tab, verify message dialog...)

Diff Detail

Event Timeline

PiRK requested review of this revision.Oct 29 2021, 10:17
Fabien requested changes to this revision.Oct 29 2021, 13:58
Fabien added a subscriber: Fabien.

The current state is obviously wrong, but the new one is also wrong when ecash=0 is used. I know it's going to be removed at some point but for now, better make it correct since you're touching it.

This revision now requires changes to proceed.Oct 29 2021, 13:58

I'm a bit reluctant to use the "Bitcoin Cash address" or "bitcoincash address" terminology, because it will confuse users more than just keeping "Bitcoin address".
What about using "eCash address" when -ecash=1 and the more vague "CashAddr" word when -ecash=0?

PiRK planned changes to this revision.Jan 20 2022, 11:39