Page MenuHomePhabricator

[cashtab] update npm and node
AbandonedPublic

Authored by kieran709 on Nov 9 2021, 20:42.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Summary

In order to fix issue with another task, npm and node have been updated.

Test Plan

cd web/cashtab
npm start
ensure app runs
npm run build
start build, ensure app runs
inspect package-lock.json to see changes

Diff Detail

Repository
rABC Bitcoin ABC
Branch
update-node-version
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17214
Build 34259: Build Diffcashtab-tests
Build 34258: arc lint + arc unit

Event Timeline

bytesofman requested changes to this revision.Nov 9 2021, 21:07

Looks like several packages were also updated here. That's okay, since we are looking to always keep with the latest version that still works with Cashtab.

I am unable to run npm start on this diff, with the following error msg:

Starting the development server...

Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:67:19)
    at Object.createHash (node:crypto:130:10)
    at module.exports (/home/joey/github/abc/bitcoin-abc/web/cashtab/node_modules/webpack/lib/util/createHash.js:135:53)
    at NormalModule._initBuildHash (/home/joey/github/abc/bitcoin-abc/web/cashtab/node_modules/webpack/lib/NormalModule.js:417:16)
    at handleParseError (/home/joey/github/abc/bitcoin-abc/web/cashtab/node_modules/webpack/lib/NormalModule.js:471:10)
    at /home/joey/github/abc/bitcoin-abc/web/cashtab/node_modules/webpack/lib/NormalModule.js:503:5
    at /home/joey/github/abc/bitcoin-abc/web/cashtab/node_modules/webpack/lib/NormalModule.js:358:12
    at /home/joey/github/abc/bitcoin-abc/web/cashtab/node_modules/loader-runner/lib/LoaderRunner.js:373:3
    at iterateNormalLoaders (/home/joey/github/abc/bitcoin-abc/web/cashtab/node_modules/loader-runner/lib/LoaderRunner.js:214:10)
    at iterateNormalLoaders (/home/joey/github/abc/bitcoin-abc/web/cashtab/node_modules/loader-runner/lib/LoaderRunner.js:221:10)
/home/joey/github/abc/bitcoin-abc/web/cashtab/scripts/start.js:11
    throw err;
    ^

Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:67:19)
    at Object.createHash (node:crypto:130:10)
    at module.exports (/home/joey/github/abc/bitcoin-abc/web/cashtab/node_modules/webpack/lib/util/createHash.js:135:53)
    at NormalModule._initBuildHash (/home/joey/github/abc/bitcoin-abc/web/cashtab/node_modules/webpack/lib/NormalModule.js:417:16)
    at handleParseError (/home/joey/github/abc/bitcoin-abc/web/cashtab/node_modules/webpack/lib/NormalModule.js:471:10)
    at /home/joey/github/abc/bitcoin-abc/web/cashtab/node_modules/webpack/lib/NormalModule.js:503:5
    at /home/joey/github/abc/bitcoin-abc/web/cashtab/node_modules/webpack/lib/NormalModule.js:358:12
    at /home/joey/github/abc/bitcoin-abc/web/cashtab/node_modules/loader-runner/lib/LoaderRunner.js:373:3
    at iterateNormalLoaders (/home/joey/github/abc/bitcoin-abc/web/cashtab/node_modules/loader-runner/lib/LoaderRunner.js:214:10)
    at iterateNormalLoaders (/home/joey/github/abc/bitcoin-abc/web/cashtab/node_modules/loader-runner/lib/LoaderRunner.js:221:10) {
  opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],
  library: 'digital envelope routines',
  reason: 'unsupported',
  code: 'ERR_OSSL_EVP_UNSUPPORTED'
}

To get this landed

  • Verify/patch npm start issue (this is probably why we are getting the npm start errors now...but we probably have to do a lot of other stuff to support this upgrade, so may need to back out of this diff and do some incremental improvements to get there)
  • Change test plan to include upgrading to node 17.1.0
  • Change summary to mention all the packages that are being upgraded

If you are also getting the npm start issue, table this for now. We should upgrade CRA first and do the node upgrade as part of that process.

This revision now requires changes to proceed.Nov 9 2021, 21:07

Awaiting upgrade to CRA before attempting to land this diff.