Page MenuHomePhabricator

wallet: remove db mode string
ClosedPublic

Authored by PiRK on Nov 12 2021, 08:54.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC74290d4c5ee5: wallet: remove db mode string
Summary

We never need to open database in read-only mode as it's controlled
separately for every batch.

Also we can safely create database if it doesn't exist already
because require_existing option is verified in MakeDatabase
before creating a new WalletDatabase instance.

This is a backport of core#20130

Notes:

  • walletdb_tests.cpp is an addtional ABC test suite introduced in D745
  • ABC does not have a CWallet::MarkReplaced method
Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable