Page MenuHomePhabricator
Differential D10500

RPC: getpeerinfo: Deprecate "whitelisted" field (replaced by "permissions")
ClosedPublic
Actions

Authored by PiRK on Nov 23 2021, 10:10.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC26109b3a5010: RPC: getpeerinfo: Deprecate "whitelisted" field (replaced by "permissions")
Summary

If we were going to continue support for "whitelisted", we should have probably made it true if any permission flag was set, rather than only if "default permissions" were used.

This corrects the description, and deprecates it.

This is a backport of core#19770

Release notes are from https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-0.21.0.md

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 23 2021, 10:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 23 2021, 10:10
PiRK requested review of this revision.Nov 23 2021, 10:10
teamcity edited the summary of this revision. (Show Details)Nov 23 2021, 10:11
Harbormaster completed remote builds in B17303: Diff 30939.Nov 23 2021, 10:25
Fabien requested changes to this revision.Nov 23 2021, 14:08
Fabien added a subscriber: Fabien.

Please add release notes for the deprecation

This revision now requires changes to proceed.Nov 23 2021, 14:08
PiRK updated this revision to Diff 30942.Nov 23 2021, 14:19

add release notes for the deprecation

PiRK updated this revision to Diff 30943.Nov 23 2021, 14:21
PiRK edited the summary of this revision. (Show Details)

newline

Fabien requested changes to this revision.Nov 23 2021, 14:26
Fabien added inline comments.
src/rpc/net.cpp
200 ↗(On Diff #30943)

you're missing the \n change here

This revision now requires changes to proceed.Nov 23 2021, 14:26
Harbormaster completed remote builds in B17306: Diff 30942.Nov 23 2021, 14:34
Harbormaster completed remote builds in B17307: Diff 30943.Nov 23 2021, 14:36
PiRK updated this revision to Diff 30952.Nov 23 2021, 16:15

include the \n change from the second commit. I wrongly assumed that this commit was only about code style, but it also changes the style of the help message.

Harbormaster completed remote builds in B17315: Diff 30952.Nov 23 2021, 16:34
Fabien accepted this revision.Nov 24 2021, 08:31
This revision is now accepted and ready to land.Nov 24 2021, 08:31
Closed by commit rABC26109b3a5010: RPC: getpeerinfo: Deprecate "whitelisted" field (replaced by "permissions") (authored by Luke Dashjr <luke-jr+git@utopios.org>, committed by PiRK). · Explain WhyNov 24 2021, 17:58
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC26109b3a5010: RPC: getpeerinfo: Deprecate "whitelisted" field (replaced by "permissions").

Revision Contents
Changeset List

PathSize
doc/
4 lines
src/
rpc/
15 lines
test/
functional/
3 lines
21 lines

Diff 30998

View Options

doc/release-notes.md

Loading...
View Options

src/rpc/net.cpp

Loading...
View Options

test/functional/p2p_blocksonly.py

Loading...
View Options

test/functional/p2p_permissions.py

Loading...