Paths

Table of Contentst

Differential D10515

[avalanche] Don't create invalid proofs in the conflicting_proof_selection test
ClosedPublic
Actions

Authored by Fabien on Nov 24 2021, 08:21.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCeeb56267d9d4: [avalanche] Don't create invalid proofs in the conflicting_proof_selection test

Summary

There is a typo in the buildProofFromAmounts lambda, and the coin added to the utxo set can have the wrong value. This has no impact on the test now because the proof is not tested for validity, but it would cause an amount mismatch error if doing so.

Test Plan

ninja check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 24 2021, 08:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 24 2021, 08:21

Fabien requested review of this revision.Nov 24 2021, 08:21

Harbormaster completed remote builds in B17328: Diff 30968.Nov 24 2021, 08:37

deadalnix accepted this revision.Nov 26 2021, 14:12

This revision is now accepted and ready to land.Nov 26 2021, 14:12

Closed by commit rABCeeb56267d9d4: [avalanche] Don't create invalid proofs in the conflicting_proof_selection test (authored by Fabien). · Explain WhyNov 26 2021, 15:09

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCeeb56267d9d4: [avalanche] Don't create invalid proofs in the conflicting_proof_selection test.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

test/

peermanager_tests.cpp

2 lines

Diff 31093

src/avalanche/test/peermanager_tests.cpp

Loading...