Paths

Table of Contentst

Differential D10516

Only update the updateSmartFeeLabel once in sync
ClosedPublic
Actions

Authored by PiRK on Nov 24 2021, 14:56.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC4a41495d0e85: Only update the updateSmartFeeLabel once in sync

Summary

Calling updateSmartFeeLabel and therefore estimateSmartFee is pointless during IBD.

GUI freezes appear because estimateSmartFee competes with processBlock for the m_cs_fee_estimator lock leading to multiple seconds of blocking the GUI thread in updateSmartFeeLabel.

This is a backport of core-gui#97

Test Plan

ninja && src/qt/bitcoin-qt

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 24 2021, 14:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 24 2021, 14:56

PiRK requested review of this revision.Nov 24 2021, 14:56

teamcity edited the summary of this revision. (Show Details)Nov 24 2021, 14:57

Harbormaster completed remote builds in B17329: Diff 30981.Nov 24 2021, 15:15

Fabien accepted this revision.Nov 25 2021, 10:44

This revision is now accepted and ready to land.Nov 25 2021, 10:44

Closed by commit rABC4a41495d0e85: Only update the updateSmartFeeLabel once in sync (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by PiRK). · Explain WhyNov 25 2021, 15:16

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC4a41495d0e85: Only update the updateSmartFeeLabel once in sync.

Revision Contents
Changeset List

Path

Size

src/

qt/

sendcoinsdialog.h

4 lines

sendcoinsdialog.cpp

14 lines

Diff 31026

src/qt/sendcoinsdialog.h

Loading...

src/qt/sendcoinsdialog.cpp

Loading...