refactor: Clean up -Wlogical-op warning
ClosedPublic
Actions

Authored by PiRK on Nov 25 2021, 09:21.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCa46f4c08b326: refactor: Clean up -Wlogical-op warning

Summary

This commit fixes core#19912 by removing a check that always returned true. That check was causing a -Wlogical-op warning because it treated a constant int as though it were a boolean.
This is a backport of core#19986

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 25 2021, 09:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 25 2021, 09:21

PiRK requested review of this revision.Nov 25 2021, 09:21

teamcity edited the summary of this revision. (Show Details)Nov 25 2021, 09:21

Harbormaster completed remote builds in B17355: Diff 31013.Nov 25 2021, 09:35

Fabien accepted this revision.Nov 25 2021, 11:08

This revision is now accepted and ready to land.Nov 25 2021, 11:08

Closed by commit rABCa46f4c08b326: refactor: Clean up -Wlogical-op warning (authored by maskoficarus <bitcoin@maskoficarus.com>, committed by PiRK). · Explain WhyNov 25 2021, 15:31

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCa46f4c08b326: refactor: Clean up -Wlogical-op warning.

Revision Contents
Changeset List

Path

Size

src/

wallet/

scriptpubkeyman.cpp

3 lines

Diff 31036

View Options

src/wallet/scriptpubkeyman.cpp

refactor: Clean up -Wlogical-op warningClosedPublicActions