Paths

Table of Contentst

Differential D10541

Warn on unknown rw_settings
ClosedPublic
Actions

Authored by PiRK on Nov 25 2021, 10:17.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC345d8e187cb4: Warn on unknown rw_settings

Summary

Log a warning to debug log if unknown settings are encountered. This should probably only ever happen when the software is upgraded.

Something similar is already done for the command line and config file. See core#16234

This is a backport of core#19624

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 25 2021, 10:17

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 25 2021, 10:17

PiRK requested review of this revision.Nov 25 2021, 10:17

teamcity edited the summary of this revision. (Show Details)Nov 25 2021, 10:17

Harbormaster completed remote builds in B17358: Diff 31016.Nov 25 2021, 10:31

Fabien accepted this revision.Nov 25 2021, 11:15

This revision is now accepted and ready to land.Nov 25 2021, 11:15

Closed by commit rABC345d8e187cb4: Warn on unknown rw_settings (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyNov 25 2021, 15:37

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC345d8e187cb4: Warn on unknown rw_settings.

Revision Contents
Changeset List

Path

Size

src/

util/

system.cpp

9 lines

test/

functional/

feature_settings.py

14 lines

Diff 31039

View Options

src/util/system.cpp