Page MenuHomePhabricator
Differential D10567

walletutil: Wallets can also be sqlite
AbandonedPublic
Actions

Authored by PiRK on Nov 26 2021, 15:00.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

This is a backport of core#19077 [19/26]
https://github.com/bitcoin/bitcoin/pull/19077/commits/9b78f3ce8ed1867c37f6b9fff98f74582d44b789i

Test Plan

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Nov 26 2021, 15:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 26 2021, 15:00
PiRK requested review of this revision.Nov 26 2021, 15:00
teamcity edited the summary of this revision. (Show Details)Nov 26 2021, 15:00
PiRK added a child revision: D10568: Use SQLite for descriptor wallets.Nov 26 2021, 15:03
Harbormaster completed remote builds in B17404: Diff 31090.Nov 26 2021, 15:45
deadalnix accepted this revision.Nov 26 2021, 16:45
deadalnix added a subscriber: deadalnix.

So at this stage, this whole thing is still untested, yet reachable by users.

This revision is now accepted and ready to land.Nov 26 2021, 16:45
deadalnix added a comment.Nov 26 2021, 16:45

And test plans still test nothing at all.

deadalnix requested changes to this revision.Nov 26 2021, 16:50

Upon looking at what comes next, this is obviously not good to go.

This revision now requires changes to proceed.Nov 26 2021, 16:50
PiRK mentioned this in D10569: Use disk magic as sqlite wallet application ID.Dec 1 2021, 08:43
PiRK abandoned this revision.Dec 1 2021, 09:17

This should be squashed with D10568, so that it is immediately covered by all functional tests supporting the --descriptorsargument.

PiRK mentioned this in D10568: Use SQLite for descriptor wallets.Dec 1 2021, 09:58
PiRK edited the summary of this revision. (Show Details)
PiRK removed a child revision: D10568: Use SQLite for descriptor wallets.Dec 1 2021, 10:13
PiRK removed a parent revision: D10566: Determine wallet file type based on file magic.

Revision Contents
Changeset List

PathSize
src/
wallet/
4 lines

Diff 31090

View Options

src/wallet/walletutil.cpp

Loading...