[Cashtab] add eToken icon to send page
AbandonedPublic
Actions

Authored by kieran709 on Dec 2 2021, 18:12.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Summary

Using the same logic as TokenListItem, eToken icon added to send page. Related to task T1988.

Custom Token:

resize-token-icons-send-page.png (1×1 px, 356 KB)

Generated Token:

resize-token-icons-send-page-2.png (1×1 px, 250 KB)

Test Plan

cd web/cashtab
npm start
navigate to eTokens tab
select a token with a custom icon
ensure icon displays at top of token table
navigate back to eTokens tab
select a token with a generated icon
ensure icon displays at top of token table

Diff Detail

Repository

rABC Bitcoin ABC

Branch

display-icon-etoken-page

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17544
Build 34914: Build Diff	cashtab-tests
Build 34913: arc lint + arc unit

Event Timeline

kieran709 created this revision.Dec 2 2021, 18:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 2 2021, 18:12

kieran709 requested review of this revision.Dec 2 2021, 18:12

Harbormaster completed remote builds in B17515: Diff 31236.Dec 2 2021, 18:16

bytesofman requested changes to this revision.Dec 2 2021, 23:05

bytesofman added inline comments.

web/cashtab/src/components/Send/SendToken.js
365 ↗	(On Diff #31236)	Just "Icon" for the label
368 ↗	(On Diff #31236)	Other available sizes here are 64, 128, 256, and 512 Try all of them and use the biggest one that works