Use importdescriptors when in descriptor wallet mode in wallet_createwallet.py
ClosedPublic
Actions

Authored by PiRK on Dec 14 2021, 14:25.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC6cabd8ddde3c: Use importdescriptors when in descriptor wallet mode in wallet_createwallet.py

Summary

sethdseed and importmulti are not available for descriptor wallets, so when doing descriptor wallet tests, use importdescriptors instead

The keypool size when using descriptor wallets is unaffected for Bitcoin ABC, because our descriptors wallets have only the p2pkh keys.

This is a backport of core#18788 [7/15]
https://github.com/bitcoin/bitcoin/pull/18788/commits/25bc5dccbfd52691adca6edd418dd54290300c28

Test Plan

test/functional/test_runner.py wallet_createwallet

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Dec 14 2021, 14:25

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 14 2021, 14:25

PiRK requested review of this revision.Dec 14 2021, 14:25

teamcity edited the summary of this revision. (Show Details)Dec 14 2021, 14:25

Harbormaster completed remote builds in B17626: Diff 31390.Dec 14 2021, 14:39

Fabien accepted this revision.Dec 15 2021, 14:03

This revision is now accepted and ready to land.Dec 15 2021, 14:03

Closed by commit rABC6cabd8ddde3c: Use importdescriptors when in descriptor wallet mode in wallet_createwallet.py (authored by Andrew Chow <achow101-github@achow101.com>, committed by PiRK). · Explain WhyDec 15 2021, 15:52

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC6cabd8ddde3c: Use importdescriptors when in descriptor wallet mode in wallet_createwallet.py.

Revision Contents
Changeset List

Path

Size

test/

functional/

test_runner.py

2 lines

wallet_createwallet.py

64 lines

Diff 31419

View Options

test/functional/test_runner.py