test: Add test for -blockversion
ClosedPublic
Actions

Authored by PiRK on Dec 15 2021, 08:16.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC81fa8f13ff79: test: Add test for -blockversion

Summary

-blockversion is currently untested, as in: The setting could be made a no-op without any tests failing. Fix that by adding an explicit test for it.

This is a backport of core#20167 [3/3]
https://github.com/bitcoin/bitcoin/pull/20167/commits/fa9b48549ca39b862a10bcfd90e3eac2a0e8ad2e

Note: we don't need the NORMAL_GBT_REQUEST_PARAMS helper, as Bitcoin ABC's normal getblocktemplate call needs no paramaters.

Test Plan

test/functional/test_runner.py mining_basic

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Dec 15 2021, 08:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 15 2021, 08:16

PiRK requested review of this revision.Dec 15 2021, 08:16

teamcity edited the summary of this revision. (Show Details)Dec 15 2021, 08:16

Harbormaster completed remote builds in B17640: Diff 31408.Dec 15 2021, 08:36

PiRK edited the summary of this revision. (Show Details)Dec 15 2021, 08:42

Fabien accepted this revision.Dec 15 2021, 14:09

This revision is now accepted and ready to land.Dec 15 2021, 14:09

Closed by commit rABC81fa8f13ff79: test: Add test for -blockversion (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyDec 15 2021, 15:55

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC81fa8f13ff79: test: Add test for -blockversion.

Revision Contents
Changeset List

Path

Size

test/

functional/

mining_basic.py

14 lines

Diff 31423

View Options

test/functional/mining_basic.py

test: Add test for -blockversionClosedPublicActions