Paths

Table of Contentst

Differential D10732

refactor: use constexpr and remove template
ClosedPublic
Actions

Authored by PiRK on Dec 23 2021, 09:16.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCdf99eb6da0e8: refactor: use constexpr and remove template

Summary

Minor follow-up to core#19845 (D10720).

The template was thought to be needed to handle both std::ios_base::failure and std::runtime_error, but they both inherit std:eexception so it is not necessary.

This is a backport of core#20033

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Dec 23 2021, 09:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 23 2021, 09:16

PiRK requested review of this revision.Dec 23 2021, 09:16

teamcity edited the summary of this revision. (Show Details)Dec 23 2021, 09:16

Harbormaster completed remote builds in B17742: Diff 31557.Dec 23 2021, 09:29

Fabien accepted this revision.Dec 23 2021, 10:24

This revision is now accepted and ready to land.Dec 23 2021, 10:24

Closed by commit rABCdf99eb6da0e8: refactor: use constexpr and remove template (authored by Vasil Dimov <vd@FreeBSD.org>, committed by PiRK). · Explain WhyDec 23 2021, 13:52

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCdf99eb6da0e8: refactor: use constexpr and remove template.

Revision Contents
Changeset List

Path

Size

src/

netaddress.h

2 lines

test/

util/

setup_common.h

3 lines

Diff 31568

View Options

src/netaddress.h