Differential D10762

[avalanche][trivial] Avoid repeated getId() during proof registration
ClosedPublic
Actions

Authored by Fabien on Jan 4 2022, 19:18.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABCa6a234112880: [avalanche][trivial] Avoid repeated getId() during proof registration

Summary

Just get the proofid once and use that instead.
There will be more callsites as the function is extended so better make it clean now.

Ref T1854.

Test Plan

ninja check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 4 2022, 19:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 4 2022, 19:18

Fabien requested review of this revision.Jan 4 2022, 19:18

Harbormaster completed remote builds in B17791: Diff 31636.Jan 4 2022, 19:32

PiRK accepted this revision.Jan 5 2022, 10:34

This revision is now accepted and ready to land.Jan 5 2022, 10:34

Closed by commit rABCa6a234112880: [avalanche][trivial] Avoid repeated getId() during proof registration (authored by Fabien). · Explain WhyJan 5 2022, 12:07

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCa6a234112880: [avalanche][trivial] Avoid repeated getId() during proof registration.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

peermanager.cpp

8 lines

Diff 31644

View Options

src/avalanche/peermanager.cpp

[avalanche][trivial] Avoid repeated getId() during proof registrationClosedPublicActions