Page MenuHomePhabricator

test: use wait_for_{block,header} helpers in p2p_fingerprint.py
ClosedPublic

Authored by PiRK on Jan 10 2022, 15:32.

Details

Summary

This small PR takes use of the message receiving helper functions wait_for_block() and wait_for_header() in the test p2p_fingerprint.py. It also simplifies the checks for very old stale blocks/headers requests by getting rid of the functions last_block_equals() and last_header_equals() and rather only testing that no blocks/headers message is received at all. Unnecessary sending of requests are also removed and calls to time.sleep(...) substituted by ping syncs.

This is a backport of core#20047

Test Plan

ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable