Differential D10824

[Cashtab] Drag and drop to reorder token list
AbandonedPublic
Actions

Authored by kieran709 on Jan 13 2022, 15:25.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Summary

User should be able to sort token in any order that they want. Related to task T1947.

Test Plan

cd web/cashtab
npm install
npm start
navigate to eToken tab
drag tokens into preferred order
hard refresh the page, or navigate to a different tab then back to eToken tab.
ensure the token list is in the same order defined in the previous step.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

reorder-token-list

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17902
Build 35627: Build Diff	cashtab-tests
Build 35626: arc lint + arc unit

Event Timeline

kieran709 created this revision.Jan 13 2022, 15:25

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 13 2022, 15:25

kieran709 requested review of this revision.Jan 13 2022, 15:25

kieran709 planned changes to this revision.Jan 13 2022, 15:25

kieran709 edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B17902: Diff 31795.Jan 13 2022, 15:28

Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests:  Wallet with BCH balances and tokens and state field ======
TypeError: Cannot read property 'droppable' of undefined
    at useDroppablePublisher (/work/web/cashtab/node_modules/react-beautiful-dnd/dist/react-beautiful-dnd.cjs.js:7408:68)
    at Droppable (/work/web/cashtab/node_modules/react-beautiful-dnd/dist/react-beautiful-dnd.cjs.js:8288:3)
    at renderWithHooks (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:6016:18)
    at mountIndeterminateComponent (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:8744:13)
    at beginWork (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:9966:16)
    at performUnitOfWork (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13800:12)
    at workLoopSync (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13728:5)
    at renderRootSync (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13691:7)
    at performSyncWorkOnRoot (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13404:18)
    at /work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:2537:26
    at unstable_runWithPriority (/work/web/cashtab/node_modules/scheduler/cjs/scheduler.development.js:646:12)
    at runWithPriority (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:2486:10)
    at flushSyncCallbackQueueImpl (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:2532:9)
    at flushSyncCallbackQueue (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:2519:3)
    at scheduleUpdateOnFiber (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13004:9)
    at updateContainer (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:16454:3)
    at Object.create (/work/web/cashtab/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:17149:3)
    at Object.<anonymous> (/work/web/cashtab/src/components/Tokens/__tests__/Tokens.test.js:88:32)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)

Each failure log is accessible here:
CashTab Unit Tests: Wallet with BCH balances and tokens and state field

kieran709 edited the test plan for this revision. (Show Details)Jan 13 2022, 17:45

Please abandon in current form. Tx history needs a significant refactor for chronik integration.

kieran709 abandoned this revision.Sep 21 2022, 13:20