Added css properties to SwButtonCtn in Configure.js to ensure consistency across themes. Related to task T2178.
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project
cd web/cashtab
npm start
navigate to Configure tab
open saved wallets list
ensure text inside Activate buttons is legible
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- swbutton-ctn-css-props
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 17943 Build 35708: Build Diff cashtab-tests Build 35707: arc lint + arc unit
Event Timeline
Comment Actions
- What task is this associated with?
- Where are these colors coming from now? Is it just antd defaults? If so, and you are enforcing a new color, it should be added to the buttons section of theme.js
| web/cashtab/src/components/Configure/Configure.js | ||
|---|---|---|
| 146 | It's weird that a button on the Configure page is pulling colors from tokenListItem I get that these colors happen to be the same, but we want theme.js to be human readable. If we want these colors to be the same in the app, we should add props.theme.buttons.savedWallet.background , then set it to some constant value that happens to be equal to props.theme.tokenListItem.background That would be outside the scope of this diff. However, I do not think that adding new theme items for props.theme.buttons.savedWallet is outside the scope of this diff. It's too confusing to assign them cherry picked colors that happen to be what we are using here. | |