Page MenuHomePhabricator
Differential D10848

Wrap seeder options in a namespace
ClosedPublic
Actions

Authored by thonkle on Jan 19 2022, 18:23.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCa285358346dc: Wrap seeder options in a namespace
Summary

Prevent symbol collisions with seeder-specific constants. This is most relevant when writing tests.

Test Plan
ninja check-seeder bitcoin-seeder

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

thonkle created this revision.Jan 19 2022, 18:23
Owners added a reviewer: Restricted Owners Package.Jan 19 2022, 18:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 19 2022, 18:23
thonkle requested review of this revision.Jan 19 2022, 18:23
Harbormaster completed remote builds in B17944: Diff 31855.Jan 19 2022, 18:53
Fabien accepted this revision.Jan 19 2022, 21:16
This revision is now accepted and ready to land.Jan 19 2022, 21:16
Closed by commit rABCa285358346dc: Wrap seeder options in a namespace (authored by thonkle). · Explain WhyJan 19 2022, 22:22
This revision was automatically updated to reflect the committed changes.
thonkle added a commit: rABCa285358346dc: Wrap seeder options in a namespace.

Revision Contents
Changeset List

PathSize
src/
seeder/
6 lines
8 lines
4 lines
test/
16 lines

Diff 31857

View Options

src/seeder/main.cpp

Loading...
View Options

src/seeder/options.h

Loading...
View Options

src/seeder/options.cpp

Loading...
View Options

src/seeder/test/options_tests.cpp

Loading...