Differential D10864

[Cashtab] Standardize testing regime
ClosedPublic
Actions

Authored by emack on Jan 22 2022, 02:42.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC128c55c78820: [Cashtab] Standardize testing regime

Summary

As part of code quality assurance, there is a need to develop a minimum test plan for Cashtab that touches on:

interactions with fresh new wallets
interactions with wallets which have old TXs relevant to the diff
regression testing of functions relating to the diff
cross browser compatibility beyond chrome
testing on physical mobile devices

We've seen some edge cases recently around these scenarios so will be ideal to have a consistent minimum test plan coverage before the Diff gets to reviewers. This will become more important as we onboard more developers and reviewers get busier.

Manifest: T2041

Test Plan

navigate to the https://github.com/Bitcoin-ABC/bitcoin-abc/tree/master/web/cashtab readme page.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emack created this revision.Jan 22 2022, 02:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 22 2022, 02:42

emack requested review of this revision.Jan 22 2022, 02:42

Harbormaster completed remote builds in B17971: Diff 31902.Jan 22 2022, 02:46

bytesofman requested changes to this revision.Jan 24 2022, 20:53

bytesofman added inline comments.

web/cashtab/README.md
27 ↗	(On Diff #31902)	While this is true, I think we should keep it out of the README. Want the content to be as procedure dense as possible with specific relevance to this repo.
31 ↗	(On Diff #31902)	Existing functions that impacted by your diff must be regression tested to ensure no unintended behavior. For example, if you're adding a function to facilitate One To Many XEC transactions, you must test that the existing One to One XEC transactions work as intended.
76 ↗	(On Diff #31902)	This includes but is not limited to: