Differential D10877

[net processing] Move ping timeout logic to net processing
ClosedPublic
Actions

Authored by Fabien on Jan 24 2022, 21:25.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABCdcaa6ed10bd6: [net processing] Move ping timeout logic to net processing

Summary

Ping messages are an application-level mechanism. Move timeout
logic from net to net processing.

Partial backport of core#20721:
https://github.com/bitcoin/bitcoin/pull/20721/commits/dd2646d12c172cb8899669af717c590483a17404

Ref T1696.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 24 2022, 21:25

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 24 2022, 21:25

Fabien requested review of this revision.Jan 24 2022, 21:25

teamcity edited the summary of this revision. (Show Details)Jan 24 2022, 21:25

Harbormaster completed remote builds in B17986: Diff 31926.Jan 24 2022, 21:41

Missing dependency, needs rebase

Fabien edited the summary of this revision. (Show Details)Jan 25 2022, 16:44

Fabien removed a parent revision: D10876: [net processing] Move send ping message logic into function.

Rebase

PiRK accepted this revision.Jan 25 2022, 16:59

This revision is now accepted and ready to land.Jan 25 2022, 16:59

Harbormaster completed remote builds in B18011: Diff 31967.Jan 25 2022, 17:06

Closed by commit rABCdcaa6ed10bd6: [net processing] Move ping timeout logic to net processing (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyJan 25 2022, 17:45

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCdcaa6ed10bd6: [net processing] Move ping timeout logic to net processing.

Revision Contents
Changeset List

Path

Size

src/

net.cpp

13 lines

net_processing.cpp

30 lines

Diff 31971

View Options

src/net.cpp