Page MenuHomePhabricator

Only select from addrv2-capable peers for torv3 address relay
ClosedPublic

Authored by Fabien on Jan 27 2022, 16:18.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABC3d475507d4ac: Only select from addrv2-capable peers for torv3 address relay
Summary
When selecting peers to relay an address to, only pick addrv2-capable ones if the address cannot be represented in addr(v1).

Without this I expect that propagation of torv3 addresses over the cleartext network will be very hard for a while.

The parameter is named _addr to prevent a shadow warning (just like PushAddress).

Backport of core#20661.

Ref T1696.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Jan 27 2022, 16:19
This revision is now accepted and ready to land.Jan 27 2022, 16:27
This revision was landed with ongoing or failed builds.Jan 27 2022, 16:34
This revision was automatically updated to reflect the committed changes.