Send and require SENDADDRV2 before VERACK
AbandonedPublic
Actions

Authored by PiRK on Jan 28 2022, 14:31.

Details

Reviewers

None

Group Reviewers

Restricted Project

Summary

See the corresponding BIP change: https://github.com/bitcoin/bips/pull/1043

The log message is from core#20724 backported out of order in D10923

This is a partial backport of core#20564
https://github.com/bitcoin/bitcoin/pull/20564/commits/1583498fb6781c01ca2f33c09319ed793964c574

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr20564

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18060
Build 35942: Build Diff	lint-circular-dependencies · build-diff · build-without-wallet · build-clang · build-debug · build-clang-tidy
Build 35941: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 28 2022, 14:31

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 28 2022, 14:31

PiRK requested review of this revision.Jan 28 2022, 14:31

teamcity edited the summary of this revision. (Show Details)Jan 28 2022, 14:31

I need to think more about what this implies regarding compatibility with previous versions of Bitcoin ABC.

Harbormaster completed remote builds in B18060: Diff 32058.Jan 28 2022, 14:44

After testing, I confirm that this patch gets a node disconnected.
If we want to follow core on this, it would have to be done as a hard fork upgrade. I do not think that we need this, as we do not need to stay compatible with version that do not support addrv2.