Page MenuHomePhabricator

Cleanup of -debug=net log messages
ClosedPublic

Authored by Fabien on Jan 28 2022, 10:23.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABCb98c847ec131: Cleanup of -debug=net log messages
Summary
A few changes to -debug=net logging:

 - always log when disconnecting a peer
 - only log various connection errors when -debug=net is enabled, since errors from random untrusted peers is completely expected
 - log when ignoring a message due to violating protocol (primarily to make it easier to debug other implementations)
 - use "peer=123" rather than "from 123" to make grepping logs a bit easier
 - log the value of the bip-37 fRelay field in version messages both when sending and receiving a version message

Some differences from the source material are due to segwit and out of order backports.

Backport of core#20724.

Ref T1696.

Test Plan
ninja all check-extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable