Page MenuHomePhabricator
Differential D10972

Refactor p2p_add_connections
ClosedPublic
Actions

Authored by Fabien on Feb 3 2022, 10:30.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABC0b586b6698e5: Refactor p2p_add_connections
Summary

This makes the code much easier to follow by avoiding a log of p2p_idx manipulations, and make it easier to changes the number of connections in the future without having to update the whole test.

Ref T1696.

Test Plan
./test/functional/test_runner.py p2p_add_connections

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Feb 3 2022, 10:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 3 2022, 10:30
Fabien requested review of this revision.Feb 3 2022, 10:30
Harbormaster completed remote builds in B18129: Diff 32163.Feb 3 2022, 11:08
PiRK accepted this revision.Feb 3 2022, 12:32
This revision is now accepted and ready to land.Feb 3 2022, 12:32
Closed by commit rABC0b586b6698e5: Refactor p2p_add_connections (authored by Fabien). · Explain WhyFeb 3 2022, 13:57
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC0b586b6698e5: Refactor p2p_add_connections.

Revision Contents
Changeset List

PathSize
test/
functional/
63 lines

Diff 32168

View Options

test/functional/p2p_add_connections.py

Loading...