In Ticker.js, removed currency.tokenExplorerUrl, and replaced value of currency.blockExplorerUrl to explorer.be.cash. In useBCH.js and useBCH.test.js, replaced each instance of currency.tokenExplorerUrl with currency.blockExplorerUrl. Related to task T2215.
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project
cd web/cashtab && npm start
From the wallet tab:
Click on an XEC transaction, ensure that the link leads to explorer.be.cash.
Click on an eToken transaction, ensure that the linke leads to explorer.be.cash.
Send eToken, click on transaction as above
Receive eToken, click on transaction as above
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- replace-remove-block-explorer
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 18249 Build 36306: Build Diff Build 36305: arc lint + arc unit
Event Timeline
Comment Actions
Good diff. Will hold off a bit on landing due to this issue:
If user clicks before BCHD has seen the tx, get a user unfriendly error msg.
Comment Actions
Even with the issues at explorer.be.cash, it's still better to get this in. So, please rebase to latest master; we'll review + land