Differential D11089

[avalanche] Fix potential failure in abc_p2p_avalanche_proof_voting
ClosedPublic
Actions

Authored by Fabien on Feb 22 2022, 08:36.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCc278bdfb2473: [avalanche] Fix potential failure in abc_p2p_avalanche_proof_voting

Summary

On rare occasion (about 1/1000 run on my machine), the test will fail to find the vote finalization message in the log, because we don't keep sending the vote over the timeout period. This diff uses a retry mechanism to work around this.

Because the default timeout for assert_debug_log is 2s and there are 5 retries, the total timeout is slightly bumped to 12s which is not significant.

Test Plan

for i in {1..10000}; do echo "Trial number $i" && ./test/functional/test_runner.py abc_p2p_avalanche_proof_voting || break; done

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Feb 22 2022, 08:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 22 2022, 08:36

Fabien requested review of this revision.Feb 22 2022, 08:36

Harbormaster completed remote builds in B18330: Diff 32478.Feb 22 2022, 08:50

PiRK accepted this revision.Feb 22 2022, 13:13

This revision is now accepted and ready to land.Feb 22 2022, 13:13

Closed by commit rABCc278bdfb2473: [avalanche] Fix potential failure in abc_p2p_avalanche_proof_voting (authored by Fabien). · Explain WhyFeb 22 2022, 14:56

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCc278bdfb2473: [avalanche] Fix potential failure in abc_p2p_avalanche_proof_voting.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc_p2p_avalanche_proof_voting.py

22 lines

Diff 32484

View Options

test/functional/abc_p2p_avalanche_proof_voting.py

[avalanche] Fix potential failure in abc_p2p_avalanche_proof_votingClosedPublicActions