[WEBSITE] Avoid null assignment when there is no link to convert in the release notes
ClosedPublic
Actions

Authored by Fabien on Mar 11 2022, 14:52.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCWEB16a5d88059ae: [WEBSITE] Avoid null assignment when there is no link to convert in the release…

Summary

Due to set -u in the fetch_documentation.sh, the script fails when there is no relative link in the release notes file because REL_LINKS is set to null. Fix it with double quotes so it's set to an empty string/array as expected.

Test Plan

./scripts/fetch_documentation.sh

Will fail on 0.25.1 before this patch.

Diff Detail

Repository

rABCWEB Bitcoin ABC Website

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Mar 11 2022, 14:52

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 11 2022, 14:52

Fabien requested review of this revision.Mar 11 2022, 14:52

Harbormaster completed remote builds in B18458: Diff 32666.Mar 11 2022, 14:52

PiRK accepted this revision.Mar 11 2022, 14:53

This revision is now accepted and ready to land.Mar 11 2022, 14:53

Closed by commit rABCWEB16a5d88059ae: [WEBSITE] Avoid null assignment when there is no link to convert in the release… (authored by Fabien). · Explain WhyMar 11 2022, 14:54

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCWEB16a5d88059ae: [WEBSITE] Avoid null assignment when there is no link to convert in the release….

Revision Contents
Changeset List

Path

Size

scripts/

fetch_documentation.sh

2 lines

Diff 32667

View Options

scripts/fetch_documentation.sh

[WEBSITE] Avoid null assignment when there is no link to convert in the release notesClosedPublicActions