txdb: don't reset during in-memory cache resize
ClosedPublic
Actions

Authored by PiRK on Mar 18 2022, 13:40.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCddb302e35b90: txdb: don't reset during in-memory cache resize

Summary

We can't support a reset of the dbwrapper object when in-memory configuration is used
because it results in the permanent loss of coins. This only affects unittest
configurations (since that's the only place we use in-memory CCoinsViewDB instances).

This is a backport of core#19806 [2/8]
https://github.com/bitcoin/bitcoin/pull/19806/commits/ad949ba449ff2115e3d22c71f5b6509f11112098

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Mar 18 2022, 13:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 18 2022, 13:40

PiRK requested review of this revision.Mar 18 2022, 13:40

teamcity edited the summary of this revision. (Show Details)Mar 18 2022, 13:40

Harbormaster completed remote builds in B18565: Diff 32842.Mar 18 2022, 14:11

Fabien accepted this revision.Mar 18 2022, 14:40

This revision is now accepted and ready to land.Mar 18 2022, 14:40

rebase to change parent commit (does not affect the behavior of this diff)
change commit sequence number from 3/8 to 2/8.

The idea is that I will maybe squash D11225 with another commit.

PiRK edited the summary of this revision. (Show Details)Mar 22 2022, 12:37

Harbormaster completed remote builds in B18590: Diff 32881.Mar 22 2022, 12:52

Closed by commit rABCddb302e35b90: txdb: don't reset during in-memory cache resize (authored by James O'Beirne <james.obeirne@pm.me>, committed by PiRK). · Explain WhyApr 12 2022, 09:42

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCddb302e35b90: txdb: don't reset during in-memory cache resize.

Revision Contents
Changeset List

Path

Size

src/

txdb.cpp

15 lines

Diff 33166

View Options

txdb: don't reset during in-memory cache resizeClosedPublicActions